-
Notifications
You must be signed in to change notification settings - Fork 405
Utilize a separate pipeline for release tasks #2515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nagilson
merged 34 commits into
dotnet:main
from
nagilson:nagilson-separate-pipeline-for-pub
Jan 9, 2026
Merged
Utilize a separate pipeline for release tasks #2515
nagilson
merged 34 commits into
dotnet:main
from
nagilson:nagilson-separate-pipeline-for-pub
Jan 9, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to link official build ci and understand logic from vscode-csharp
Removes the actual publish step to prevent accidentally publishing for now
nagilson
commented
Dec 4, 2025
the 'signed' package is already created and overrides the unsigned one.
default test to true so we dont accidentally ship
MiYanni
approved these changes
Dec 11, 2025
jaredpar
reviewed
Jan 7, 2026
I believe we would fail when trying to expand .version out, but this is a cleaner approach. I've also adjusted the call to vsce to expand arguments properly and suppressed a linter issue that surfaced when pinning the linter version - in which the linter is not quite aware that we are running a Promise<R> returning function
See comment 'await must be used to make the linter allow f to be async, which it must be' above, which elaborates on why the lint rule does not apply to this unusual context of passing an async function object
MiYanni
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Succeeds #2411
To migrate to a standardized deployment approach, we'd like to move away from the legacy Azure DevOps release mechanisms. The best way I've seen to do that is to have a separate release pipeline which handles only release activities - the release pipeline must be quite restricted which causes issues even trying to run our security scanners and compliance tools such as SBOM, so trying to create a deployment off our existing pipeline served challenging.
This approach is based off of the vscode-csharp release pipeline. https://github.com/dotnet/vscode-csharp/blob/main/azure-pipelines/release.yml
An example run is here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2858298&view=results
Other updates to make this work:
npm ciinstall of vsce. This is because we are blocked from installing updates in a ci machine so it would fail anytime a package sub dependency got an update (which happens nearly daily)Thank you to @/joerobich who was very helpful in explaining the vscode-csharp-release structure.